Skip to content

Testing bot#34

Closed
dhruvmanila wants to merge 29 commits intomasterfrom
testing_bot
Closed

Testing bot#34
dhruvmanila wants to merge 29 commits intomasterfrom
testing_bot

Conversation

@dhruvmanila
Copy link
Owner

@dhruvmanila dhruvmanila commented Nov 23, 2020

  • Open a pull request
  • Add awaiting reviews label
  • Skip checks as made by owner
  • Check PR files
  • Add require labels
  • Remove awaiting reviews label

@ghost ghost added awaiting reviews and removed require tests labels Nov 24, 2020
ghost
ghost reviewed Dec 1, 2020
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by dhruvmanila
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 Relevant links:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue.

test-pygithub[bot]
test-pygithub bot reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@test-pygithub test-pygithub bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

check_pr_files.py
"""
A test function
"""
return False
Copy link
Contributor

@test-pygithub test-pygithub bot Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide doctest for the function.

@dhruvmanila
Copy link
Owner Author

dhruvmanila commented Dec 26, 2020

@algorithms-keeper review-all

@dhruvmanila
Copy link
Owner Author

dhruvmanila commented Dec 26, 2020

@algorithms-keeper review-all

Repository owner deleted a comment Dec 26, 2020
@dhruvmanila
Copy link
Owner Author

dhruvmanila commented Dec 26, 2020

@algorithms-keeper review-all

@ghost
Copy link

ghost commented Dec 26, 2020 •
edited by dhruvmanila
Loading

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

check_pr_files.py:1: As there is no test file in this pull request nor any test function or class in the file check_pr_files.py, please provide doctest for the function test1

check_pr_files.py:1: Please provide type hint for the parameter: abc

check_pr_files.py:8: Please provide type hint for the parameter: emhb

check_pr_files.py:16: Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

check_pr_files.py:19: Please provide descriptive name for the parameter: a

Content format: [file path]:[line number]: [message]

@dhruvmanila
Copy link
Owner Author

dhruvmanila commented Feb 18, 2021

@algorithms-keeper review-all

@ghost
Copy link

ghost commented Feb 18, 2021

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

check_pr_files.py:1: As there is no test file in this pull request nor any test function or class in the file check_pr_files.py, please provide doctest for the function test1

check_pr_files.py:1: Please provide type hint for the parameter: abc

check_pr_files.py:8: Please provide type hint for the parameter: emhb

check_pr_files.py:16: Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

check_pr_files.py:19: Please provide descriptive name for the parameter: a

Content format: [file path]:[line number]: [message]

@dhruvmanila
Copy link
Owner Author

dhruvmanila commented Feb 18, 2021

@algorithms-keeper review

@dhruvmanila dhruvmanila deleted the testing_bot branch February 18, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@test-pygithub test-pygithub[bot] test-pygithub[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviews enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhruvmanila